This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-avoid-r9] ARM: Use r10 instead of r9.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Thu, 28 Feb 2013 16:54:19 +0000
- Subject: Re: [PATCH roland/arm-avoid-r9] ARM: Use r10 instead of r9.
- References: <20130228010102.162DD2C0A1@topped-with-meat.com>
On Wed, 27 Feb 2013, Roland McGrath wrote:
> The arm-nacl ABI reserves r9 for the system (as EABI says some variants
> might). r10 is just the same for other instruction-set and ABI issues,
> so this uses r10 in place of r9.
This will need updating for the push/pop patch that I approved. Apart
from that,
> @@ -237,18 +237,18 @@ ENTRY(memmove)
> orr r5, r5, r4, pull #\pull
> mov r4, r4, push #\push
> orr r4, r4, r3, pull #\pull
> - stmdb r0!, {r4 - r9, ip, lr}
> + stmdb r0!, {r4 - r10, ip, lr}
looks like it should use r4 - r8, r10 rather than r4 - r10, and similarly
> - ldmfd sp!, {r5 - r9}
> + ldmfd sp!, {r5 - r10}
looks like it should be r5-r8, r10. How was this patch tested?
--
Joseph S. Myers
joseph@codesourcery.com