This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch to handle cgroup and btrfs filesystems

From: Andreas Jaeger <aj at suse dot de>
To: Richard Henderson <rth at twiddle dot net>
Cc: libc-hacker at sourceware dot org
Date: Fri, 1 Oct 2010 21:49:15 +0200
Subject: Re: Patch to handle cgroup and btrfs filesystems
References: <201010010632.57347.aj@suse.de> <4CA5FDA4.2060705@twiddle.net>

On Friday 01 October 2010 17:26:28 Richard Henderson wrote:
> On 09/30/2010 09:32 PM, Andreas Jaeger wrote:
> >  /* Constant that identifies the `bfs' filesystem.  */
> >  #define BFS_MAGIC		0x1BADFACE
> > 
> > +/* Constant that identifies the `btrfs' filesystem.  */
> > +#define BTRFS_SUPER_MAGIC	0x1BADFACE
> > +
> > +/* Constant that identifies the `cgroup' filesystem.  */
> > +#define CGROUP_SUPER_MAGIC	0x1BADFACE
> 
> 3 identical magic's can't be put into the same switch
> statements.  How did this compile for you?

I tested the wrong tree, not sure how emacs tricked me, I copied the values ;-(

thanks for noticing, here's the fix.  This time tested with the right tree,
Andreas

2010-10-01  Andreas Jaeger  <aj@suse.de>

	* sysdeps/unix/sysv/linux/linux_fsinfo.h (BTRFS_SUPER_MAGIC): Fix value.
	(CGROUP_SUPER_MAGIC): Likewise.

diff --git a/sysdeps/unix/sysv/linux/linux_fsinfo.h b/sysdeps/unix/sysv/linux/linux_fsinfo.h
index 8efbdea..b671d2c 100644
--- a/sysdeps/unix/sysv/linux/linux_fsinfo.h
+++ b/sysdeps/unix/sysv/linux/linux_fsinfo.h
@@ -38,10 +38,10 @@
 #define BFS_MAGIC		0x1BADFACE
 
 /* Constant that identifies the `btrfs' filesystem.  */
-#define BTRFS_SUPER_MAGIC	0x1BADFACE
+#define BTRFS_SUPER_MAGIC	0x9123683E
 
 /* Constant that identifies the `cgroup' filesystem.  */
-#define CGROUP_SUPER_MAGIC	0x1BADFACE
+#define CGROUP_SUPER_MAGIC	0x27e0eb
 
 /* Constant that identifies the `coda' filesystem.  */
 #define CODA_SUPER_MAGIC	0x73757245


-- 
 Andreas Jaeger, Program Manager openSUSE,  aj@{novell.com,opensuse.org}
  Twitter: jaegerandi | Identica: jaegerandi
   SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
    Maxfeldstr. 5, 90409 Nürnberg, Germany
     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

References:
- Patch to handle cgroup and btrfs filesystems
  - From: Andreas Jaeger
- Re: Patch to handle cgroup and btrfs filesystems
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]