This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] check_pf.c: Include alloca.h

I've tried the build with gcc-4.2 for SH and got an error like

  xsh-libc-gcc4/libc.so.6: undefined reference to `__libc_use_alloca'

It seems that the undefined reference happens on check_pf.os.
Currently sysdeps/unix/sysv/linux/check_pf.c uses alloca without
including alloca.h.  Although this is not a problem on x86 because
alloca.h is included indirectly on that architecture, it looks
that other users of alloca function include alloca.h explicitly.
How about the attached one-liner?

Regards,
	kaz
--
2007-07-06  Kaz Kojima  <kkojima@rr.iij4u.or.jp>

	* sysdeps/unix/sysv/linux/check_pf.c: Include alloca.h.

--- ORIG/libc/sysdeps/unix/sysv/linux/check_pf.c	2007-06-18 09:03:48.000000000 +0900
+++ LOCAL/libc/sysdeps/unix/sysv/linux/check_pf.c	2007-07-04 09:13:50.000000000 +0900
@@ -25,6 +25,7 @@
 #include <string.h>
 #include <time.h>
 #include <unistd.h>
+#include <alloca.h>
 #include <sys/socket.h>
 
 #include <asm/types.h>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]