This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fixes for make clean

From: Andreas Jaeger <aj at suse dot de>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Fri, 07 Jan 2005 14:58:21 +0100
Subject: Re: Fixes for make clean
References: <m3sm5ibwe5.fsf@gromit.moeb><20050107124425.GB17169@sunsite.mff.cuni.cz>

Jakub Jelinek <jakub@redhat.com> writes:

> On Mon, Jan 03, 2005 at 12:10:58PM +0100, Andreas Jaeger wrote:
>> 2005-01-03  Andreas Jaeger  <aj@suse.de>
>> 
>> 	* elf/Makefile (tests): Change rule for tst-pie1 so that make
>> 	clean works.
>> 
>> --- elf/Makefile	27 Oct 2004 20:26:47 -0000	1.287
>> +++ elf/Makefile	3 Jan 2005 11:10:36 -0000
>> @@ -1,4 +1,4 @@
>> -# Copyright (C) 1995-2002, 2003, 2004 Free Software Foundation, Inc.
>> +# Copyright (C) 1995-2004, 2005 Free Software Foundation, Inc.
>>  # This file is part of the GNU C Library.
>>  
>>  # The GNU C Library is free software; you can redistribute it and/or
>> @@ -163,7 +163,7 @@ tests-nodlopen-yes = nodlopen nodlopen2
>>  tests-execstack-yes = tst-execstack tst-execstack-needed tst-execstack-prog
>>  endif
>>  ifeq (yesyes,$(have-fpie)$(build-shared))
>> -tests: $(objpfx)tst-pie1.out
>> +tests += tst-pie1
>>  endif
>>  modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \
>>  		testobj1_1 failobj constload2 constload3 unloadmod \
>
> This change is bad:
> make[2]: Entering directory
> `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> ../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
> mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf
>
> I think putting tst-pie1.out and tst-pie1 into generated instead would cure
> this.

I'll revert my patch now,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Follow-Ups:
- [PATCH] Fixes for make clean (take 2)
  - From: Jakub Jelinek

References:
- Fixes for make clean
  - From: Andreas Jaeger
- Re: Fixes for make clean
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]