This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: INTERNAL_SYSCALL and function calls in arguments

Andreas Schwab <schwab@suse.de> writes:

> Thorsten Kukuk <kukuk@suse.de> writes:
>
>> Hi,
>>
>> sched_setaffinity has the following code:
>>
>> INTERNAL_SYSCALL (sched_getaffinity, err, 3, getpid(), psize, p)
>
> Here is a patch to fix the INTERNAL_SYSCALL macro for x86_64 and ia64.
> The definition on arm is probably also affected, but I can't test it.

The x86-64 version is ok.  The question is just whether we want to go
this road - or fix sched_getaffinity instead.  I consider it safer to
change INTERNAL_SYSCALL.

But we should check all other platforms, a brief look shows:
- m68k, x86 are ok
- x86-64, ia64: Fixed with your patch
- arm: Might need changes
- s390, s390x: Look also broken.
- ppc,ppc64, sparc, alpha, sh, mips, hppa, : Might need changes


Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]