This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "linux-snps-arc at lists dot infradead dot org" <linux-snps-arc at lists dot infradead dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Sat, 7 Mar 2020 00:37:08 +0000
- Subject: Re: [PATCH v3 17/17] ARC: changes to enable 64-bit time_t, off_t, ino_t etc
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jCP8DX9trspltYrF+Izv2tD5yHoM8rn6M+u8cvti/Qk=; b=B041m1R3+jDKokHFDOGZVgT9HyFSk96dqSs66tIy9xmUKFlsqoXQqR7l55FHbqcqhFzk9mprAwql+e5+djo7+XfmsckV+KOWZqMQ/E4Wfc+aXEFfl9rY/RKdhIrKSTN5vu79KGcxCNfg8oDuWg0nDFdwOjwVDmOcIi2JYPTS5wNOD1r6b30y0eK7h3iMAw/QvOzQEy7xQNUSw/6d7BfChcRbz53StyctRPDHbSZ9wXMKaxzwTIFECBhhw5oekypmrtBba7L4krHlkzMeuTWj5yEDxh1wHsUAPRPg1QJG4vmp8mYvbK0fGZ1AINL/QDDJ6IAxn0+glf2bWkcSPo/duA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnZFEMNtKWcHfh85d8r+yH+7tPLQJMWU0B+DHXzLqULBEr/c+BQzy0fox8dDWnm8VRVbdBcanNomNWOrXlS6JYXb1VIutC9UWqmKxYtxpKHi62itx+2QEoCveEcCXMpopGPLwXvgh28hSUhtgmxVidbRqqyNa7JNro5r0RHXulVEQWEd9fg49o7IaOeXLdV7e2Y6p0w8zf3d9jhziCoCLZV+p/LM23aTwvhzCowyZYktnKAYRo0uSKxe2u+hA0PJCEdtEasOpdCcoG4oGPrN25QgBCkYcGZ3M82oHjy0hL5U1QUul7uikfjXt/Hi96ktWDWOkWYFs78EjGmMuAseXQ==
- References: <20200306182419.13945-1-vgupta@synopsys.com> <20200306182419.13945-18-vgupta@synopsys.com> <alpine.DEB.2.21.2003070016420.26274@digraph.polyomino.org.uk>
On 3/6/20 4:19 PM, Joseph Myers wrote:
> On Fri, 6 Mar 2020, Vineet Gupta wrote:
>
>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>> ---
>> .../sysv/linux/arc/bits/socket-constants.h | 4 +--
>
> There is a general principle for patch series: you should not have later
> patches fixing up things that were wrong with earlier patches. Each patch
> should add files in the form desired to be reviewed, not in a form that
> gets fixed up later.
>
> (Sometimes a patch series might change a file that was correct in an
> earlier patch in the series, as part of adding additional features, if the
> first M patches add feature X and the next N add feature Y on top of it.
> But that's not the case here - such later patches should not make
> incompatible changes to earlier ones.)
I agree and you've mentioned this fact before as well. The only reason I carved it
this way was to ease my testing. The 64-bit time code was based on RV32 which in
turn was based on bleeding edge upstream some of which needed additional work for
ARC but ininitial days of 64-bit work, it was hard to know if the fix was needed
for 64-bit or for upstream tracking. And that's exactly what I got bitten by -
when I missed the fixup for init constructor invocation from Florian, wasting 3
days [1]
Anyhow that's just to give you the context. I can split them up and add to
respective sections for next iteration. If we end up not doing another iteration
- hypothetically speaking :-) the whole port is anyhow committed as 1 patch so it
doesn't matter.
[1] http://lists.infradead.org/pipermail/linux-snps-arc/2020-February/006974.html