This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] manual: Fix inconsistent declaration of wcsrchr [BZ #24655]
- From: DJ Delorie <dj at redhat dot com>
- To: Girish Joshi <girish946 at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 06 Mar 2020 16:38:08 -0500
- Subject: Re: [PATCH] manual: Fix inconsistent declaration of wcsrchr [BZ #24655]
Girish Joshi <girish946@gmail.com> writes:
> Subject: [PATCH] manual: Fix inconsistent declaration of wcsrchr [BZ #24655]
>
FYI a slightly more verbose summary and justification would be nice in
the future - something like what I'm including below, just to give some
background about why the patch is "correct".
Otherwise, LGTM! Thanks!
Reviewed-by: DJ Delorie <dj@redhat.com>
(the manual is outside my usual area, so I'll wait a few days for
dissent before committing)
> -@deftypefun {wchar_t *} wcsrchr (const wchar_t *@var{wstring}, wchar_t @var{c})
> +@deftypefun {wchar_t *} wcsrchr (const wchar_t *@var{wstring}, wchar_t @var{wc})
wchar.h has:
extern wchar_t *wcsrchr (const wchar_t *__wcs, wchar_t __wc)
__THROW __attribute_pure__;
wcsrchrc has:
wchar_t *
WCSRCHR (const wchar_t *wcs, const wchar_t wc)
string.texi has:
@deftypefun {wchar_t *} wmemset (wchar_t *@var{block}, wchar_t @var{wc}, size_t @var{size})
@deftypefun {wchar_t *} wmemchr (const wchar_t *@var{block}, wchar_t @var{wc}, size_t @var{size})
@deftypefun {wchar_t *} wcschr (const wchar_t *@var{wstring}, wchar_t @var{wc})
@deftypefun {wchar_t *} wcschrnul (const wchar_t *@var{wstring}, wchar_t @var{wc})