This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linux: Add soft-fp folder for arm with --without-fp



On 04/03/2020 21:55, Joseph Myers wrote:
> On Wed, 4 Mar 2020, Adhemerval Zanella wrote:
> 
>> Currently --without-fp does not add the soft-fp folder before
>> the generic dbl-64 and flt-32 on arm-linux-gnueabi.  This patch adds
>> the required Implies file (similar as powerpc, mips32, and
>> m68k-coldfire have done).
> 
> There hasn't been a --without-fp configure option since commit 
> 8df5d34720dd71e934545bade879e04697830757, so this commit message is 
> clearly wrong.

Indeed, I clearly forgot about this patch and I was fooled by a lingering
comment in configure.ac.

> 
> Based on disassembling a 2.27 binary (2.27 being the first release after 
> the sysdeps/ieee754/soft-fp directory was added), the sysdeps ordering was 
> working then, but I confirm it's broken now.  Thus this raises the 
> question of when the ordering broke, and thus (a) whether it might have 
> broken for any other configurations using sysdeps/ieee754/soft-fp at the 
> same time, and thus need fixing for them, (b) whether the breakage broke 
> ordering for anything other than nofpu directories and (c) whether it 
> might need a bug filed in Bugzilla if the issue was present in a release.  
> The addition of /le sysdeps directories is one change that might have had 
> a risk of breaking such ordering, but I don't know if it was that or not.
> 

It was the LE/BE sysdeps patch, I will send a new version.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]