This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "arnd at arndb dot de" <arnd at arndb dot de>, "linux-snps-arc at lists dot infradead dot org" <linux-snps-arc at lists dot infradead dot org>, "alistair23 at gmail dot com" <alistair23 at gmail dot com>, "lukma at denx dot de" <lukma at denx dot de>
- Date: Mon, 24 Feb 2020 19:27:46 +0000
- Subject: Re: [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yOV7/rQoKQrA0NIUH3Nsfifn+cr5bMfne/sMeb3kVJk=; b=UCk0d8Y6DuJQaBzmlYuu7nsFemMRYWgxkWYebNrqXQRK8crivVWmBwIQJ+zmR/FQdkrxGYHHzLxVCurwrrZKwGKbRqOTPCLEgqkLXZ2/vED2kSvMizCmaWIfMpdNvhStXmMFUj+yR4Q/8mOF8zDtDOVH/6JJ9K1WJCzPq+dLqI+Kuuw/6pR+HrJA8dWPx8Zzvb/2ziiAKSggBGB+lvYElo6Ww9xq5vt/d9pc6vj8jJfR/0HfBqkeUTgpOm4OhDIu+se455+GHOVfg5517D5Ml9W4DFHrVXezP8EHbYZ16JyFbYG6nWWEMM/RHaY1RNHXG86RV1stVG/jXQNVc5IC6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9y6EZEhs2khjWcnJSUVJXqcmn2T+FkjP9ehyM9P7MzFaaAiFVvwD2sxizLf5UCW4kESxt1xYUwHcRockHQ8A8IXJq4FQAC9xBcajCmhr3Eh3N+Z4+6QGEJD4+jtmc2OyWYjywMXYo9Hp34gGlXaTlJnVPwja5AAFAK+U4YcD27Im2+29xYOTcy65nC9aDJil0N9L+FzNfIB7drMnRVaEnH4lkgglf8ijhMN079gxs0Vg5/Ocu75cNPzJ2wOIrdg5vXb5L6ApPjEV3SnltRZdPHV45mGz5MMBP48dseRQKWw/ojfbUsu9K4yXFeLV/5IUImPr2IS15pTGX3KVcRc1Q==
- References: <20200224182305.28027-1-vgupta@synopsys.com> <87wo8bn839.fsf@oldenburg2.str.redhat.com> <d56495ad-c532-9e00-7f67-fa2626f9d901@synopsys.com> <87d0a3n6iq.fsf@oldenburg2.str.redhat.com>
On 2/24/20 11:13 AM, Florian Weimer wrote:
> * Vineet Gupta:
>
>> On 2/24/20 10:39 AM, Florian Weimer wrote:
>>>> +# undef STAT64_IS_NOT_KERNEL_STAT64
>>> Sorry, I think that going forward, we prefer that such macros are always
>>> defined, with values 0 or 1 as appropriate.
>>
>> And that means we also need to additionally define this to 0 in all
>> ports which don't end up including the generic header ?
>
> Yes, or move the definition into its own header, with the default for
> *future* architectures (not the majority of the current architectures)
> in the header in the sysdeps/unix/sysv/linux directory.
Adding a new file would seem too kludgy. Adding it to existing arch headers is
still OK but then one needs to know what exact syscall ABI each arch has as even
asm-generic ones differ depending on when the linux port was merged. And the only
way to know that is to do a build for each arch or is there some documentation one
could refer to.
Thx,
-Vineet