This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Avoid ldbl-96 stack corruption from range reduction of pseudo-zero (bug 25487) [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 13 Feb 2020 14:26:13 +0000
- Subject: Re: Avoid ldbl-96 stack corruption from range reduction of pseudo-zero (bug 25487) [committed]
- Ironport-sdr: UTz4GKNkcxeFv7mH6gXE53Wi6OYq60Y8726oYKZOVGLZrs0IBjE2y/b0nohf/O0Nal9D5wldA6 BHH7nEesWFKg8creVYh/32ow+xAUzXcdaFKQfOEvaFfZ7gPKTvRHYZoW5tSN1d/Ik32GN0Fa03 ck8xPqzil9wMx3qKDz0mMj6o6EYXnRWkzf+e8xt3rYTPapuwgqZp43vNzbMmvEMXjSVl1TAMG6 GdXhx1+1IU4yL3xDmzLW0G7zJ20Msp4k2tgruIY7p9yh2vw4ODdqylHr3TtQlE/s9s2K0Y6em5 qHs=
- Ironport-sdr: SPgyL5aozf0giEzhQlTTk7+/0tYc4Isow8FZADBH8Fmyg2OiJXMuOoHpdj6dlx+CHqc9NK8G/A ZxqqI9g6mgyZWY3S8nXGsv7ypNQQOsZ6xur+bofh+TrX0yNNNPkV1SRvWLiJA2fTLgoc7EjXKi ieVakCopyuHRDe/+7npdY2w2pK0HUioztxEYOD2pgWOISlYK8kwQpZMRBHx7i1+GJTzJcvg9fF VD0PY0wFoPw6swZbYhOK5NyNSHVCqhYmVvd7LGfC+nFtXV/LyJpVvb3f+xIDFHy+nR+aywevqG Lws=
- References: <alpine.DEB.2.21.2002122331510.29921@digraph.polyomino.org.uk> <87lfp6vlbw.fsf@mid.deneb.enyo.de>
On Thu, 13 Feb 2020, Florian Weimer wrote:
> Thanks for fixing this. Unfortunately, the test doesn't build on ia64
> because GCC does not support -fstack-protector-all there:
>
> cc1: error: ‘-fstack-protector’ not supported for this target [-Werror]
> cc1: all warnings being treated as errors
> make[3]: *** [/mnt/scratch1/fw/bmg/default/build/glibcs/ia64-linux-gnu/glibc/sysd-rules:639: /mnt/scratch1/fw/bmg/default/build/glibcs/ia64-linux-gnu/glibc/math/test-sinl-pseudo.o] Error 1
It looks like ifeq ($(have-ssp),yes) will be needed around that CFLAGS
setting. (I took the unconditional CFLAGS setting from where such a
setting is used in debug/Makefile, but I see that in fact the addition of
the test there is conditional. In this case, the test is appropriate
unconditionally, it's just the use of -fstack-protector-all that needs to
be conditional.)
--
Joseph S. Myers
joseph@codesourcery.com