This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] Add a generic scalb implementation
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 12 Feb 2020 01:21:16 +0000
- Subject: Re: [PATCH 6/6] Add a generic scalb implementation
- Ironport-sdr: X3XNTNnn2PT5IKO28W0qN7fcmrJBoMc/y3TiXfmj0ESoy+oSpzg27ibo/8P35y+U6kcylukmfS Jf8GILa/O88JyjVlYTgBiuyOyUit3G5ZW73SBUZJE7bJfPVAxTSmH0ejO1dF3JCMT0rMOV/coV dQqH/X1gyEs0TptJYrUkx1fuKYZ3KIO/GMbtREdnPAjXMe2GXV0lmtCY2y1xdbPJC3kStBrneO R4GaICEybZqLu1laMoxE4chp+nXzesguTUfKXYuwCkE83PIAr8G/pSqHe4drv1br1sCiowjKGk t/Y=
- Ironport-sdr: tU/KU5K0YR4pysHYzSQZkFcAsJXv2nmxmbw9Pvzrzb+Vcdl7eVSgmg4RHP8vkrU9YHlGYA94HL KHC90DuYr+pWP6oP0M7EdkHSfsdsEWYNRhOwvegyawsIirM732IGNzctrEYiQlDn0tCNgDeXam MvbnICHZjkrwJg40WmOrnQYSSGbm0SM7F8Q+zvcY7EyRPG5/7XM0IAWjxfXtEEmHD3KAjx3Ve5 ZKzTTrPrJZaYzE7bjU5vwa6tg8jBX2INZUnZTCQg4TwDWgZRGdWyTPuY2mu4IbMUF5PYnGm5sz gb8=
- References: <cover.1580757509.git.murphyp@linux.vnet.ibm.com> <938d4a14c41385b4a5c8144b029e3caa84353115.1580757509.git.murphyp@linux.vnet.ibm.com> <f9500590-3ee0-3b84-bc19-556117f7411f@linux.ibm.com>
On Tue, 11 Feb 2020, Paul E Murphy wrote:
> Tested on x86_64 and ppc64le. I've also built/check-abi csky to verify the
> LIBM_SVID_COMPAT changes still generate the appropriate symbols for those
> arches not requiring the compat versions.
I think a complete build-many-glibcs build is appropriate here. It's also
important to verify that it's still the case that no scalbf128 is built -
that on platforms with _Float128, all the *scalbf128* object files contain
no code (via the sysdeps/ieee754/float128 versions taking precedence).
> > +/* Wrapper scalb */
> > +FLOAT
> > +M_DECL_FUNC (__scalb) (FLOAT x, FLOAT fn)
> > +{
> > + {
> > + FLOAT z = M_SUF (__ieee754_scalb) (x, fn);
The indentation seems wrong here, as well as having an unnecessary layer
of braces.
Please repost the patch for review with these issues fixed and a more
detailed commit message with some explanation of the patch and its
motivation.
--
Joseph S. Myers
joseph@codesourcery.com