This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/15] powerpc: Consolidate Linux syscall definition
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Feb 2020 20:43:40 +0100
- Subject: Re: [PATCH 01/15] powerpc: Consolidate Linux syscall definition
- References: <20200210192038.23588-1-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> +/* Define __set_errno() for INLINE_SYSCALL macro below. */
> +#ifndef __ASSEMBLER__
> +#include <errno.h>
> +#endif
Missing indentation (but the existing files are not consistent about
that).
> +/* Pointer mangling support. */
> +#if defined(__PPC64__) || defined(__powerpc64__)
> +# define LOAD ld
> +# define TPREG r13
> +#else
> +# define LOAD lwz
> +# define TPREG r2
> +#endif
Can you restrict those to #ifdef __ASSEMBLER__? <sysdep.h> is a
fairly widely included header, and this has the potential of breaking
future changes that compile on other architectures.
Rest looks okay to me, but maybe a POWER maintainer wants to have a
look as well.