This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] sparc32: fix struct ipc64_perm type definition
- From: David Miller <davem at davemloft dot net>
- To: arnd at arndb dot de
- Cc: sam at ravnborg dot org, stable at vger dot kernel dot org, ldv at altlinux dot org, dalias at libc dot org, libc-alpha at sourceware dot org, sparclinux at vger dot kernel dot org, linux-kernel at vger dot kernel dot org
- Date: Tue, 21 Jan 2020 13:27:25 +0100 (CET)
- Subject: Re: [PATCH] sparc32: fix struct ipc64_perm type definition
- References: <20200114132633.3694261-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 14 Jan 2020 14:26:14 +0100
> As discussed in the strace issue tracker, it appears that the sparc32
> sysvipc support has been broken for the past 11 years. It was however
> working in compat mode, which is how it must have escaped most of the
> regular testing.
>
> The problem is that a cleanup patch inadvertently changed the uid/gid
> fields in struct ipc64_perm from 32-bit types to 16-bit types in uapi
> headers.
>
> Both glibc and uclibc-ng still use the original types, so they should
> work fine with compat mode, but not natively. Change the definitions
> to use __kernel_uid32_t and __kernel_gid32_t again.
>
> Fixes: 83c86984bff2 ("sparc: unify ipcbuf.h")
> Link: https://github.com/strace/strace/issues/116
> Cc: <stable@vger.kernel.org> # v2.6.29
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: "Dmitry V . Levin" <ldv@altlinux.org>
> Cc: Rich Felker <dalias@libc.org>
> Cc: libc-alpha@sourceware.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied and queued up for -stable, thanks Arnd.