This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] getaddrinfo: Fix resource leak after strdup failure in gethosts [BZ #25425]

From: Florian Weimer <fweimer at redhat dot com>
To: Siddhesh Poyarekar <siddhesh at gotplt dot org>
Cc: libc-alpha at sourceware dot org
Date: Mon, 20 Jan 2020 18:39:06 +0100
Subject: Re: [PATCH] getaddrinfo: Fix resource leak after strdup failure in gethosts [BZ #25425]
References: <87eevuukon.fsf@oldenburg2.str.redhat.com> <0331a154-5261-e32f-c7af-ed0cc346b80a@gotplt.org>

* Siddhesh Poyarekar:

> On 20/01/20 10:30 pm, Florian Weimer wrote:
>> Filip Ochnik spotted that one of the error jumps in gethosts fails to
>> call __resolv_context_put to release the resolver context.
>> 
>> Fixes commit 352f4ff9a268b81ef5d4b2413f582565806e4790 ("resolv:
>> Introduce struct resolv_context [BZ #21668]") and commit
>> 964263bb8d650f1681665c55704fb01a8e725621 ("getaddrinfo: Release
>> resolver context on error in gethosts [BZ #21885]").
>> 
> OK for master.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Thanks, pushed.

Florian

References:
- [PATCH] getaddrinfo: Fix resource leak after strdup failure in gethosts [BZ #25425]
  - From: Florian Weimer
- Re: [PATCH] getaddrinfo: Fix resource leak after strdup failure in gethosts [BZ #25425]
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]