This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix maybe-uninitialized error on powerpc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Matheus Castanho <msc at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>, <siddhesh at sourceware dot org>
- Date: Fri, 17 Jan 2020 22:04:38 +0000
- Subject: Re: [PATCH v2] Fix maybe-uninitialized error on powerpc
- Ironport-sdr: L4A+ATNPVlBNXxynTv9MK5woEFiJjh5iwDcDQKZRs8TlH8rLnCzjJXonmibFxWXlls4WDsWfQH IMJgQQGy+vhVHz3NQRtAT1m214FSQZG0JcUCOxQz6iHswPs8zih5gbkBRHauY0qMxzVZrCIDmF QaKzSO1S9bHcdkNl/oTJDDdBLbkhtMEavoAeLTW6Qb6AahyJssmp1kJqt9qeeu/s5QQKYUYCTr U6cpw8HA8NjphQ8Ggs/7MXBUFz9NU05EKJ7O2gEg9hvDrXbMP8nv/e/BeR3zhi+uSeBd9CXkBr Tr4=
- Ironport-sdr: 0czZJOTo3xYs1D46w/jJXrkgIPNAgXDePBefZnPS64vX9T4/TaSDewZ2MxrV5GW0fCgyEB0aqw KahtpSgOeOmw==
- References: <20200117144454.22045-1-msc@linux.ibm.com>
On Fri, 17 Jan 2020, Matheus Castanho wrote:
> +
> + /* t == 0 will never happen at this point, since 1/t can only be 0 if t is
> + infinity, but before the division t == mantissa of x (exponent is 0). We
> + can instruct the compiler to ignore this case. */
> + if (t == 0)
> + __builtin_unreachable();
This needs a space before '()'.
OK with that change, but Siddhesh will need to confirm if it's OK to push
at this development stage, and you'll need to say if you need someone to
push it for you.
--
Joseph S. Myers
joseph@codesourcery.com