This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH v3 1/3] elf: Allow dlopen of filter object to work [BZ #16272]
- From: David Kilroy <David dot Kilroy at arm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 17 Jan 2020 16:38:24 +0000
- Subject: RE: [PATCH v3 1/3] elf: Allow dlopen of filter object to work [BZ #16272]
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lMXso5KqfIOJ0mxxVzp0oJGQ15LuJB6YYt6qRDuUMxw=; b=W+TmsGvgrmMn+OMvbHBTSGhGEkqrHz0SDnapkZpB1jZtvyhHTJcVp/Mf5Zv/3nEZnXfXToQirzvH8tnVIAHvCPdetSVhiGGPpT1h36SYnGI1Rxa3bt471uzMN2f5QJwN3du3oiDluEmh3q89XKPkxHzd9N314SfmGJf2jaIaVB78Ye8hE06aSBOiQs9ebiJBsvcndkwpL8YAokwEekwzQD9piqr8klXP9Qwc2pPNq1Vl2vKmDTTVHBJuaxtIFITFX6ykeaDVFuTtzmodB3BHgtuzPhxVyhoWudc6Gydna6AVSXxMM+RvbG6Fw+Qo/45IuKitxkEFpCKhkj9pepeORQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kckgEVi2lJN5mSJIchi3aNkJcjONhthgQQxkywUcWXpjBwgMjXdh99zQwwUkCYalndn+pZvc7pDpAIFeUdqqQ0jKol2CVizzK+aVik83otG9b8LT4/4Wla9MBDThmgx+ib6Ibs0N4ByUOpCYBj11ffHYnQ2ZfniG7oZyqlQdAYOhFEbvzqc6jGWKZDhtHGQKDnadI8XXXDJKYIxlJjwJsNbNZhe2HnONoS2gfcNPvltmmOL6/SU6OBa9j9D7mXM5rzjx40729eHGg78P7c0XZV7xT6UJ+koD1FaEy2GbjI3jCStjh07cn312Mdq6eGM13ciQCP1+AFW3ZfcDQUxceA==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=David dot Kilroy at arm dot com;
- References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> <1575394197-18006-2-git-send-email-david.kilroy@arm.com> <2729fb89-bc76-6b15-8f52-50322e6d0307@linaro.org>
> -----Original Message-----
> From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> > diff --git a/elf/dl-deps.c b/elf/dl-deps.c
> > index c29b988..bb85c83 100644
> > --- a/elf/dl-deps.c
> > +++ b/elf/dl-deps.c
> > @@ -550,13 +550,14 @@ Filters not supported with
> LD_TRACE_PRELINKING"));
> > }
> >
> > /* Maybe we can remove some relocation dependencies now. */
> > - assert (map->l_searchlist.r_list[0] == map);
>
> Ok, the first entry is the filtee object.
>
> > struct link_map_reldeps *l_reldeps = NULL;
> > if (map->l_reldeps != NULL)
> > {
> > - for (i = 1; i < nlist; ++i)
> > + for (i = 0; i < nlist; ++i)
> > map->l_searchlist.r_list[i]->l_reserved = 1;
> >
> > + /* Avoid removing relocation dependencies of the main binary.
> */
> > + map->l_reserved = 0;
> > struct link_map **list = &map->l_reldeps->list[0];
> > for (i = 0; i < map->l_reldeps->act; ++i)
> > if (list[i]->l_reserved)
> > @@ -581,16 +582,32 @@ Filters not supported with
> LD_TRACE_PRELINKING"));
> > }
> > }
> >
> > - for (i = 1; i < nlist; ++i)
> > + for (i = 0; i < nlist; ++i)
> > map->l_searchlist.r_list[i]->l_reserved = 0;
> > }
>
> I am trying to understand why we can't skip first element here. Neither
> of the tests actually exercise this code patch (they won't add a
> dependency on l_reldeps), so could you provide an example/testcase
> where it requires such change?
I haven't observed the use case that this code handles. I just tried to
maintain the existing behaviour that we avoid doing this for the main object.
I've been trying to understand what triggers this, but not getting very far.
Does anyone have any hints as to how I need to setup the test so that we do
trigger relocation removals?
Thanks,
Dave.