This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove incorrect alloc_size attribute from pvalloc [BZ #25401]

From: Florian Weimer <fweimer at redhat dot com>
To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Fri, 17 Jan 2020 14:14:45 +0100
Subject: Re: [PATCH] Remove incorrect alloc_size attribute from pvalloc [BZ #25401]
References: <87h80uqsv4.fsf@oldenburg2.str.redhat.com> <9d9ed1d5-aaea-256f-6eab-677c9915b8b3@linaro.org>

* Adhemerval Zanella:

> On 17/01/2020 07:28, Florian Weimer wrote:
>> pvalloc is guarantueed to round up the allocation size to the page
>> size, so applications can assume that the memory region is larger
>> than the passed-in argument.  The alloc_size attribute cannot express
>> that.
>> 
>> The test case is based on a suggestion from Jakub Jelinek.
>> 
>> This fixes commit 9bf8e29ca136094f73f69f725f15c51facc97206 ("malloc:
>> make malloc fail with requests larger than PTRDIFF_MAX (BZ#23741)").
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

Thanks.

Siddhesh, should we put this into the release?

Florian

Follow-Ups:
- Re: [PATCH] Remove incorrect alloc_size attribute from pvalloc [BZ #25401]
  - From: Siddhesh Poyarekar

References:
- [PATCH] Remove incorrect alloc_size attribute from pvalloc [BZ #25401]
  - From: Florian Weimer
- Re: [PATCH] Remove incorrect alloc_size attribute from pvalloc [BZ #25401]
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]