This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809]
- From: Mike FABIAN <mfabian at redhat dot com>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>
- Cc: libc-alpha at sourceware dot org, Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Date: Wed, 15 Jan 2020 10:00:20 +0100
- Subject: Re: [PATCH 2/2] Add new locale: ckb_IQ (Kurdish/Sorani spoken in Iraq) [BZ #9809]
- References: <s9dimleie1q.fsf@taka.site> <92994978.1038459.1579039780291@poczta.nazwa.pl>
Rafal Luzynski <digitalfreak@lingonborough.com> さんはかきました:
>> mon_grouping 3
>> -positive_sign ""
>> -negative_sign "<U002D>"
>> +positive_sign "+"
>> +negative_sign "-"
>
> This is not a simple change because it replaces an empty string
> in the positive_sign field with "+". Are you sure this is correct?
They said so in the bug report:
https://sourceware.org/bugzilla/show_bug.cgi?id=9809#c58
(In reply to Jwtiyar Nariman from comment #56)
> Thank you mike you your help is really appreciated
> I have pointed all my answers according to your question and suggestion to
> our locale as follow:
>
> 1. For positive sign and negative i agree with you let it be + and - .
Your original locale had the positive sign empty.
Probably a mistake. So I’ll make it + now.
>> [...]
>> -
>> LC_MESSAGES
>> -yesexpr "<U0628><U06D5><U06B5><U06CE>"
>> -noexpr "<U0646><U06D5><U062E><U06CE><U0631>"
>> +yesexpr "^[+1yY<U0628>]"
>> +noexpr "^[-0nN<U0646>]"
>
> Correct!
>
> Otherwise this patch is either correct or I am unable to verify.
> I don't give my "Reviewed-by" because this review is very incomplete.
> But unless anyone else opposes feel free to push it.
>
> Of course, we need a permission from Siddhesh (CC)
>
> Regards,
>
> Rafal
>
--
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。