This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[RFC v6 18/23] RISC-V: Fix llrint and llround missing exceptions on RV32
- From: Alistair Francis <alistair dot francis at wdc dot com>
- To: libc-alpha at sourceware dot org
- Cc: arnd at arndb dot de, adhemerval dot zanella at linaro dot org, fweimer at redhat dot com, joseph at codesourcery dot com, palmerdabbelt at google dot com, macro at wdc dot com, zongbox at gmail dot com, alistair dot francis at wdc dot com, alistair23 at gmail dot com
- Date: Sun, 12 Jan 2020 02:34:19 -0800
- Subject: [RFC v6 18/23] RISC-V: Fix llrint and llround missing exceptions on RV32
- Ironport-sdr: KpjQZZg00VZRAxudXheshjh2F9I0/z0B1EBnpZPi1uior8XCgkajW4m1mF/XgYjVNqpkCrBBGz EQsjdWviqdaN9OCAcvg+YO3CrIefK5NrYWIvZ+OWJb6mzwnNPumAa3hQsT3yBoNHVWGfPGFNxn 4mZZZik7mGm1x3KYTaMuTiDKmr9A05TsgwcLoUuvgbs63jWvC2hp6KBn9dGV6v+KxRI/5TcSbl u4eS+okXA8FLm73fXGPV8jnUettrc5yStR+nWXakK5eRygNTw7uD8cWsCYidCCfQNSHD059vs2 XjQ=
- Ironport-sdr: +2WuDWUwwF2AJI05WSuw5amniIokds59NW2VjI5P2lgHgj/6fX96bIJpAP7Y7CSnGCvhlmGPyh xlYYQNVkEUTg1KxfMzSFiaS1+WD3owK3G/zp8DLRcyOUoAFIq8jOirIqFlCTYMLtoz7U2+TCix Pkgryif00dPvg4UxX29sbz6oEe1CbKxHv/etkNr2gBliYq347bJoC7cVne3CgJKurKw+FeW2j5 AZwxVdXNGjZNUEqhA9so7D0F31joKEe5zBQSlwZqg3fRqWfvaPHVVRWAZfTV089iLGT0kDCkCF /8muRAcfPOMBeVlzxBVl4Lwj
- Ironport-sdr: 0rzpYub+Df91PUDq0fzRG4QGx1m6wv1qV5bzGf9Eo2v4IOoXeH2Nm62rUCw1XzA5u4c7Fsq6ri LWWcddK6I9U5Mmh+WjYbj7/x0wfurwWrzGecrBJfJ19RoSbL9hHt2l8AJvSG31EwBPC+RvuogZ TZ8pooePYCCm41y8M1cP/PTcpMnnTwOEJJymLQx/eOsX4x+VEIgKnDm/hsAmn3rimDl8ocd5Oa 45fPV1CGJdEq0tqT6qdaWnBBfXJm0/VLUhOwkz1wQfFaFrcz0d4zO80u4Q2UJ1WwUOALqotYst iUk=
- References: <cover.1578824547.git.alistair.francis@wdc.com>
- Wdcironportexception: Internal
From: Zong Li <zongbox@gmail.com>
Similar to the fix for MIPS, ARM and S/390, RV32 is missing
correct exception on overflow from llrint and llround functions because
cast from floating-point types to long long do not result in correct
exceptions on overflow.
---
.../riscv/rv32/fix-fp-int-convert-overflow.h | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
new file mode 100644
index 0000000000..9137ee0fd8
--- /dev/null
+++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
@@ -0,0 +1,38 @@
+/* Fix for conversion of floating point to integer overflow. RISC-V version.
+ Copyright (C) 2015-2020 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
+
+/* The generic libgcc2.c conversions from floating point
+ to long long may not raise the correct exceptions on overflow (and
+ may raise spurious "inexact" exceptions even in non-overflow cases,
+ see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>). */
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+
+#endif /* fix-fp-int-convert-overflow.h */
--
2.24.1