This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 7 Jan 2020 19:05:29 -0300
- Subject: Re: [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY
- References: <20191210204710.4832-1-hjl.tools@gmail.com> <20191210204710.4832-4-hjl.tools@gmail.com>
On 10/12/2019 17:47, H.J. Lu wrote:
> diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S
> index d59c127501..a21d5f69b3 100644
> --- a/sysdeps/unix/sysv/linux/i386/_exit.S
> +++ b/sysdeps/unix/sysv/linux/i386/_exit.S
> @@ -21,6 +21,7 @@
> .type _exit,@function
> .global _exit
> _exit:
> + _CET_ENDBR
> movl 4(%esp), %ebx
>
> /* Try the new syscall first. */
>
Do we still need this for i386? I think the generic implementation
should suffice since __NR_exit_group is always support and
i386 does define ABORT_INSTRUCTION.