This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 1/2] y2038: linux: Provide __timerfd_gettime64 implementation
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: Lukasz Majewski <lukma at denx dot de>, Joseph Myers <joseph at codesourcery dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, Andreas Schwab <schwab at suse dot de>, Alistair Francis <alistair23 at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at gotplt dot org>, Florian Weimer <fweimer at redhat dot com>, Florian Weimer <fw at deneb dot enyo dot de>, Zack Weinberg <zackw at panix dot com>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Tue, 7 Jan 2020 21:22:52 +0100
- Subject: Re: [PATCH v4 1/2] y2038: linux: Provide __timerfd_gettime64 implementation
- References: <20200106121742.1628-1-lukma@denx.de> <ea1ea005-6dee-f8dd-f205-d0a47a952904@linaro.org> <20200107102752.396f7f6f@jawa> <b09ec981-7cf4-19e8-74b9-74c558ba0e75@linaro.org> <20200107152521.7416d5f3@jawa> <a4198224-902a-9955-1d5f-92765ba0abae@linaro.org>
On Tue, Jan 7, 2020 at 9:16 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> On 07/01/2020 11:25, Lukasz Majewski wrote:
> >> On 07/01/2020 06:27, Lukasz Majewski wrote:
> >>
> >>>> As a side note, now that arch-syscall patch is upstream should we
> >>>> assume that for !__ASSUME_TIME64_SYSCALLS the
> >>>> __NR_timerfd_gettime64 should be defined (meaning that Linux
> >>>> supports time64 for all 32-bit architectures)?
> >>>
> >>> Only Linux version >= 5.1 supports 64 bit time on archs with
> >>> __WORDSIZE = 32. I do guess (but I may be wrong here) that the
> >>> arch-syscall is supposed to reflect the exact syscalls provided by
> >>> kernel headers used for building (to help with validation of Y2038
> >>> patches).
> >>
> >> The arch-syscall is now autogenerated from the latest kernel release
> >> defined in build-many-glibcs.py. So the question is whether Linux
> >> support and enforces time64 support on all and future 32-bit
> >> architectures or if there is still some missing ones (as it has
> >> happen on some syscall additions, where some architecture lag
> >> behind some releases).
> >
> > This question would be best answered by Arnd (CC'ed) IMHO. From what I
> > know all 32 bit architectures gained syscalls covered by
> > __ASSUME_TIME64_SYSCALLS from Linux 5.1+.
> >
> > The arch-syscall seems to me like a mean to test for example the time
> > related syscalls which use different versions (32bit time vs 64 bit) on
> > different archs. Notable example - clock_gettime(). Am I right?
>
> The arch-syscall is a way to decouple the build from the kernel header
> used on build, which might simplify the logic to use some kernel
> features.
>
> On the clock_gettime, for instance, as Arnd has indicated we can
> assume that __NR_clock_gettime64 will be always presented for
> !__ASSUME_TIME64_SYSCALLS.
>
> It would be interesting if kernel also could enforce that new
> generic syscalls would be wire-up, or at least the syscall number
> reserved; once a new generic syscall is introduced. It would
> simplify the __ASSUME_* macro, not requiring the arch-specific
> overrides on some architectures.
We currently try to enforce it through review since the introduction
of the automatically generated asm/unistd.h header files, but his
has already failed one time for the recent clone3 system call that
accidentally was missing on one architecture.
I have some plans to enforce it using tooling, but it should
at least be a safe assumption that all new system calls have
the same numbers across all architectures and are added at
the same time.
I also have some vague plans to automatically generate not
only the asm/unistd.h header but also some trivial wrappers
around syscall() that provide an inline function with the correct
arguments, to allow calling any syscall without relying on libc
to provide a wrapper for it.
Arnd