This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reserve static TLS for dynamically loaded initial-exec TLS only [BZ #25051]
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: nd <nd at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 7 Jan 2020 12:50:17 +0000
- Subject: Re: [PATCH] Reserve static TLS for dynamically loaded initial-exec TLS only [BZ #25051]
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MIFdrNCTaCbMc0WGdMPoTsozzJUAgAkZG6uxJkILITk=; b=H7jSNzmupZhMNa1OLoHIx4MXXfIDoPHwWiP5eooEN8tFcbIdG00U3BzPhEqD5VDl8BTgyneCMfA33zn0NXfbB3TOY7A/HzykYxOFI9c1+g3KWEMoOhaf1nl+i4ZVv7yuGywVb4Ln0y4+/NqV1pg8afK/03QASEdY0Jzmgey6ZfuiUiVE9SdSvDUaQeW2m6p0BprooTpfhrdoeIBY214YZ88eJmWjrSNJD7qxipyYDN9USvU4ubcwOGq876L8J4+eSRxSgAALrUaUloevG0hCi87GvsiqDsGw6goDYRH5MXgA7EbEZNubQzz9/T0XAD2F/+CQkECHD16mCDocAmBTaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WL9JV+xSK6I9Jp94gbzKpPv18tOlPK46L/DAr75rr20uJwD2iBNG+Xlw8B3ui+qoLoNMc5JI7I/rIQMsBdH/r/Vu0OA2LZ2SBuA5UGlR4UShl5Mzg0hQ2Ctot4MuxnIFysyzWunWYItHsDtEhJT0mrfviIFSv5QHYc/XlTeVuOSXh9qlu+rFHfIhJZ0c0yrbNvdrTL+ok4jLjePGFKnQRWhRKmkorwyI5ZDWzmPSIO0h+NO2C79ukzn5yYDiSc/LckRCLGnLReH+ADnYEaApC6EVrCmlCMPWgDiK/j6ZcIERdMJz0su11wVKtfc2m+ZsGTuKYlSh/tvfKpsbU+dUgQ==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- References: <44eaccc2-f760-88c0-989a-e413e328b051@arm.com> <87lfqjv56h.fsf@oldenburg2.str.redhat.com>
On 07/01/2020 12:09, Florian Weimer wrote:
> * Szabolcs Nagy:
>
>> This patch reserves 128 bytes of the surplus TLS that is not used
>> opportunistically. TLS_STATIC_SURPLUS is currently 1664, so this still
>> allows 1536 bytes for opportunistic use. A new test is added to verify
>> this ABI contract: dynamic loading of libraries with initial-exec TLS
>> is supported up to 128 bytes in total on all targets. This should be
>> enough for system libraries such as libgomp.
>
> I'm not sure if it's enough for loading another libc.so.6 via dlmopen.
> Have you tested this, by chance?
i haven't tested, but that wont work reliably with
this patch.
libc.so on aarch64 has 144 byte TLS (8byte alignmed),
so the reserved 128byte surplus TLS is not enough
(can be increased to 144 though).
however if a lib with ie TLS is loaded before the static
TLS runs out then that works: the 128byte reserve will be
kept available until the 'opportunistic' part of TLS runs
out and then the reserve can only be used for ie TLS.
(so early dlmopen of libc.so.6 and later dlopen of libgomp
works)
this may not be an ideal solution: if all the ie TLS libs
are loaded early then reserving 128 byte at the end is not
that useful.
but using dlmopen to load multiple instances of libc and
libgomp and libopengl etc will not work reliably because
we can't keep enough static TLS reserve for that: if that's
the preferred behaviour then glibc should not use static
TLS opportunistically for TLSDESC and ppc TLS opt.