This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, libc-alpha at sourceware dot org
- Date: Thu, 2 Jan 2020 10:50:09 -0300
- Subject: Re: [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips
- References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-14-adhemerval.zanella@linaro.org> <c4a9b680-aca2-0d95-d884-92014b3915eb@gotplt.org>
On 02/01/2020 10:13, Siddhesh Poyarekar wrote:
> On 18/12/19 3:17 am, Adhemerval Zanella wrote:
>> It was added on Linux 5.4 (commit 1f66c45db3302).
>> ---
>> sysdeps/unix/sysv/linux/mips/sysdep.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/sysdeps/unix/sysv/linux/mips/sysdep.h b/sysdeps/unix/sysv/linux/mips/sysdep.h
>> index c2bec03806..67a2f74df2 100644
>> --- a/sysdeps/unix/sysv/linux/mips/sysdep.h
>> +++ b/sysdeps/unix/sysv/linux/mips/sysdep.h
>> @@ -16,11 +16,16 @@
>> License along with the GNU C Library. If not, see
>> <http://www.gnu.org/licenses/>. */
>>
>> +#include <sgidefs.h>
>> +
>
> Do you need this at all? It seems to me that the compiler sets _MIPS_SIM.
The compiler does sets _MIPS_SIM, but it might not define _ABIXX
(for instance -mabi=32 does not define _ABI64).
>
>> #define VDSO_NAME "LINUX_2.6"
>> #define VDSO_HASH 61765110
>>
>> /* List of system calls which are supported as vsyscalls. */
>> #define HAVE_CLOCK_GETTIME_VSYSCALL "__vdso_clock_gettime"
>> +#if _MIPS_SIM != _ABI64
>> +#define HAVE_CLOCK_GETTIME64_VSYSCALL "__vdso_clock_gettime64"
>> +#endif
>> #define HAVE_GETTIMEOFDAY_VSYSCALL "__vdso_gettimeofday"
>> #define HAVE_CLOCK_GETRES_VSYSCALL "__vdso_clock_getres"
>>
>>
>