This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] Linux: Add tables with system call numbers
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 2 Jan 2020 11:25:21 +0530
- Subject: Re: [PATCH 1/5] Linux: Add tables with system call numbers
- References: <cover.1576588849.git.fweimer@redhat.com> <ed280e2b33c96f9a1bd84810db91d2b680b24ba1.1576588849.git.fweimer@redhat.com> <56247f60-bee7-9624-37bf-1453c06c7088@gotplt.org> <87zhf8n3j4.fsf@mid.deneb.enyo.de> <0b6f5557-e67f-b92f-269d-163c8df2d3c8@gotplt.org> <87woaclbwd.fsf@mid.deneb.enyo.de> <cdc18b59-72b2-a422-e4d6-be680c8c9a6c@gotplt.org> <875zhwl7ax.fsf@mid.deneb.enyo.de>
On 31/12/19 11:13 pm, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>> On 31/12/19 9:34 pm, Florian Weimer wrote:
>>> I'll see what I can do about this. It will require quite a bit
>>> re-testing.
>>>
>>
>> Thanks, the freeze (I'm evaluating and writing that email as I write
>> this) will be slushy at least till the end of this week. At worst (i.e.
>> if you can't make it by the end of the week), we can conclude the review
>> and you can commit it right after release.
>>
>>> No, there are system call tables which are shared across tuples,
>>> e.g. little-endian and big-endian variants. These also get updated
>>> multiple times.
>>>
>>> The only alternative would be to lock a different file, perhaps
>>> sysdeps/unix/sysv/linux/Makefile. I don't know the impact yet on the
>>> execution time.
>>
>> OK, we can hold off on that, the current version of this bit is fine.
>
> Here's a new version of the patch, with the file comment and the
> atomic file replacement.
>
Thank you, this looks good to me. Please commit the patchset before end
of your day on Friday.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>