This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] Linux: Add tables with system call numbers
On 31/12/2019 08:22, Florian Weimer wrote:
> * Siddhesh Poyarekar:
>
>>> diff --git a/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h
>>> new file mode 100644
>>> index 0000000000..163f618499
>>> --- /dev/null
>>> +++ b/sysdeps/unix/sysv/linux/aarch64/arch-syscall.h
>>
>> Prefix the auto-generated files with a comment header like so:
>>
>> /* AUTOGENERATED by update-syscall-lists.py. DO NOT EDIT. */
>
> I'm concerned that this unnecessarily makes processing by tools more
> difficult, so I'd like to avoid this.
But isn't the idea of the script to always regenerate the file? I see this
kind of warning valuable to guide either a developer or an user to find
into the generation tools instead of hack the file itself for possible
solutions.
Rest looks ok to me, I would maybe extend the commit message to add the
information from cover-letter on how to fully update the arch-syscall.h
table once a new kernel is released.
Thanks for working on this, this decouple is something I would like to
push on glibc.