This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH 1/2] uapi: split openat2(2) definitions from fcntl.h
- From: David Laight <David dot Laight at ACULAB dot COM>
- To: 'Aleksa Sarai' <cyphar at cyphar dot com>, Florian Weimer <fweimer at redhat dot com>
- Cc: Alexander Viro <viro at zeniv dot linux dot org dot uk>, Jeff Layton <jlayton at kernel dot org>, "J. Bruce Fields" <bfields at fieldses dot org>, Shuah Khan <shuah at kernel dot org>, Christian Brauner <christian dot brauner at ubuntu dot com>, "dev at opencontainers dot org" <dev at opencontainers dot org>, "containers at lists dot linux-foundation dot org" <containers at lists dot linux-foundation dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "linux-api at vger dot kernel dot org" <linux-api at vger dot kernel dot org>, "linux-fsdevel at vger dot kernel dot org" <linux-fsdevel at vger dot kernel dot org>, "linux-kernel at vger dot kernel dot org" <linux-kernel at vger dot kernel dot org>, "linux-kselftest at vger dot kernel dot org" <linux-kselftest at vger dot kernel dot org>
- Date: Thu, 19 Dec 2019 14:05:04 +0000
- Subject: RE: [PATCH 1/2] uapi: split openat2(2) definitions from fcntl.h
- References: <20191219105533.12508-1-cyphar@cyphar.com> <20191219105533.12508-2-cyphar@cyphar.com> <87a77oy3oe.fsf@oldenburg2.str.redhat.com> <20191219134525.mgzmjbsp4wo5b2bw@yavin.dot.cyphar.com>
From: Aleksa Sarai
> Sent: 19 December 2019 13:45
> On 2019-12-19, Florian Weimer <fweimer@redhat.com> wrote:
> > * Aleksa Sarai:
> >
> > > diff --git a/include/uapi/linux/openat2.h b/include/uapi/linux/openat2.h
> > > new file mode 100644
> > > index 000000000000..19ef775e8e5e
> > > --- /dev/null
> > > +++ b/include/uapi/linux/openat2.h
> > > @@ -0,0 +1,41 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > > +#ifndef _UAPI_LINUX_OPENAT2_H
> > > +#define _UAPI_LINUX_OPENAT2_H
> >
> > I think you should include the relevant header for __align_u64
> > etc. here.
>
> Right -- no idea why I forgot to include them.
I'm guessing that is just 64bit aligned on 32bit archs like x86?
No need to enforce it provided the structure will have no padding
on archs where the 64bit fields are 64bit aligned.
A plain __u64 should be fine.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)