This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] aarch64: Optimized memset for Kunpeng processor.
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Xuelei Zhang <zhangxuelei4 at huawei dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "siddhesh at gotplt dot org" <siddhesh at gotplt dot org>, Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, "jiangyikun at huawei dot com" <jiangyikun at huawei dot com>, "yikunkero at gmail dot com" <yikunkero at gmail dot com>
- Date: Wed, 18 Dec 2019 14:29:57 +0000
- Subject: Re: [PATCH v3] aarch64: Optimized memset for Kunpeng processor.
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3z4INXcUBU3uBuW0tWi6GT4Y0NJ4VZjZ44h2NnG24AE=; b=lop8Vxf0kH4Ne0t903W4lvCP3uPq2lGgGkqNCCjZwUXWTVW9ltS3WvGjbbRP1feU8OGscMqkU+df0BI9lqzfXpuTslRgif6I/lQ8YDOfFiX1kYkTY6ITndf6Ah2huikgIOOPgJOF7TcYhKQlMB2UlZ6HCI2bqAStRlE98igD6Sl+LVVuhKPYOCRu6eAXas41YDbmdv6FCxkVdIzf+pBNZgH5KJyPOrhCk3Rj6XFq6o1Pz7eZy5n3ViDZTJJUtKQgstIP43nDkZUaEz7SOlBifM2f5oqr6aOKlPZ/YXRpnxPahppK0ltJbqhq/Wr/eDZDze4vh3x/+MKLMbFvpWLLIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPRqAnxczi4uZceNJbULHSZKGrysOrunN/dSUeIpvmhdFtrJJ5pEowPrsg3x+RUfgyNGEVKMB2ZfnbJ8e8AzXelMITCkL/hQ11EfAWBUT6Jo4LhFj01q9t9OHznGAkBtuzZlTX+sv/EA8qCNLqFFs8JmxvHK8kw6zwTWC2q359GLbWRHxz02ppzCt9S39Broy8sBNr3sODVul60Ip8UxprOZQoNFcZV+9o9qiSI4bHl7p1WL6YoQF2mfEpFiLZla7RJmm0FOIei2UhPillYNJM+zYnr7f7lEuq5S8SMHd0W4TEJTBVmDBygJP4NUsX8rnQ5u0cbVScYs5skpqpblYg==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
- References: <20191104084939.30876-1-zhangxuelei4@huawei.com>
Hi Xuelei,
This version looks much better and has addressed most issues, so is OK.
It's still beaten by __memset_emag for cases > 128 bytes, so you might want
to look into improving the loop further (including making sure it is aligned
to a fetch boundary).
Cheers,
Wilco