This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] time: Introduce glibc's internal struct __itimerspec64
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 4 Dec 2019 16:41:32 -0300
- Subject: Re: [PATCH 1/5] time: Introduce glibc's internal struct __itimerspec64
- References: <20191111214758.3677-1-lukma@denx.de> <20191111214758.3677-2-lukma@denx.de>
On 11/11/2019 18:47, Lukasz Majewski wrote:
> This change provides the glibc's internal struct itimerspec representation,
> which is explicitly supporting 64 bit time (by using struct __timespec64).
>
> Such representation is necessary to provide correct time after Y2038
> (time_t overflow) on devides with __TIMESIZE == 32.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> include/time.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/time.h b/include/time.h
> index d7800eb30f..52ee213669 100644
> --- a/include/time.h
> +++ b/include/time.h
> @@ -82,6 +82,17 @@ struct __timespec64
> };
> #endif
>
> +#if __TIMESIZE == 64
> +# define __itimerspec64 itimerspec
> +#else
> +/* The glibc's internal representation of the struct itimerspec. */
> +struct __itimerspec64
> +{
> + struct __timespec64 it_interval;
> + struct __timespec64 it_value;
> +};
> +#endif
> +
> #if __TIMESIZE == 64
> # define __ctime64 ctime
> #else
>
Ok, __timespec64 already handles both the padding and endianess.