This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 13/13] Use GCC builtins for copysign functions if desired.
On Wed, 4 Dec 2019, Stefan Liebler wrote:
> > I think they can all be 1, given that IBM long double has its own
> > implementation. Except that you shouldn't need the indirection through
> > these macros at all. Just use __builtin_copysign etc. directly in the
> > implementations (other than IBM long double), unconditionally, the same
> > way that sysdeps/ieee754/dbl-64/s_fabs.c uses __builtin_fabs directly
> > without such macros being needed.
> >
>
> Okay. I've set them to 1 and also used build-many-glibcs.py and had a look
> into the s_copysign*.os files. There is no function call to copysign* itself.
I think we should handle this like fabs and not have the macros at all,
just call __builtin_copysign etc. unconditionally.
--
Joseph S. Myers
joseph@codesourcery.com