This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Correct range checking in mallopt/mxfast/tcache [BZ #25194]
- From: DJ Delorie <dj at redhat dot com>
- To: "Carlos O'Donell" <codonell at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 03 Dec 2019 23:47:42 -0500
- Subject: Re: [patch] Correct range checking in mallopt/mxfast/tcache [BZ #25194]
"Carlos O'Donell" <codonell@redhat.com> writes:
> Does this allow mallopt to accept an invalid large negative
> value but after wrapping be treated as less than MAX_TCACHE_SIZE
> and thus be accepted instead of rejected?
Only if sizeof(int) > sizeof(size_t), which for our targets never
happens. Negative values passed to mallopt will now result in failure,
because they'll map to positive size_t larger than MAX_TCACHE_SIZE.
Plus MAX_TCACHE_SIZE is "very small"