This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Correct range checking in mallopt/mxfast/tcache [BZ #25194]
- From: DJ Delorie <dj at redhat dot com>
- To: Jonathan Nieder <jrnieder at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 03 Dec 2019 22:47:04 -0500
- Subject: Re: [patch] Correct range checking in mallopt/mxfast/tcache [BZ #25194]
Jonathan Nieder <jrnieder@gmail.com> writes:
> nit: unsigned overflow is defined in C to wrap around, so we don't
> have to worry about undefined behavior here.
Including implied overflow by type cast conversions?
> This also changes the return value from these helpers. Forgive my
> ignorance: where do they get called? I assumed it would be
> __libc_mallopt, but I don't see any calls from there.
The only two places they could be called from is mallopt() and the
tunables macros in arena.c. The tunables code ignores any return value.