This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 3 Dec 2019 13:58:34 -0300
- Subject: Re: [PATCH v2 18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold
- References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-19-gabriel@inconstante.net.br> <27a1e236-5146-2fc7-972b-5438a57c68f2@linux.ibm.com> <20191127144738.3f5b5086@tereshkova>
On Wed, 27 Nov 2019, Gabriel F. T. Gomes wrote:
>On Thu, 14 Nov 2019, Paul E Murphy wrote:
>
>>On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
>>>
>>> + if (read != (long double) -1)
>>
>>Trivial nit, any reason to avoid using -1.0L directly (likewise for
>>test-wcstold-ldbl-compat.c)?
>
>No reason, really. I applied this suggestion locally (in both files).
Now pushed with this change. Thanks.