This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v3] nptl: Add default pthreadtypes-arch.h
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Fri, 22 Nov 2019 06:51:32 -0500
- Subject: [review v3] nptl: Add default pthreadtypes-arch.h
- Auto-submitted: auto-generated
- References: <gerrit.1573136666000.Ie0cd586258a2650f715c1af0c9fe4e7063b0409a@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/520
......................................................................
Patch Set 3:
(1 comment)
| --- /dev/null
| +++ sysdeps/nptl/bits/pthreadtypes-arch.h
| @@ -1,0 +27,19 @@ # define __SIZEOF_PTHREAD_ATTR_T 56
| +# define __SIZEOF_PTHREAD_MUTEX_T 40
| +# define __SIZEOF_PTHREAD_RWLOCK_T 56
| +# define __SIZEOF_PTHREAD_BARRIER_T 32
| +# define __SIZEOF_PTHREAD_COND_T 48
| +#else
| +# define __SIZEOF_PTHREAD_ATTR_T 36
| +# define __SIZEOF_PTHREAD_MUTEX_T 24
| +# define __SIZEOF_PTHREAD_RWLOCK_T 32
| +# define __SIZEOF_PTHREAD_BARRIER_T 20
| +# define __SIZEOF_PTHREAD_COND_T 48
PS3, Line 36:
I think this could also be moved out of the conditional.
| +#endif
| +#define __SIZEOF_PTHREAD_MUTEXATTR_T 4
| +#define __SIZEOF_PTHREAD_RWLOCKATTR_T 8
| +#define __SIZEOF_PTHREAD_BARRIERATTR_T 4
| +#define __SIZEOF_PTHREAD_CONDATTR_T 4
| +
| +#define __LOCK_ALIGNMENT
| +#define __ONCE_ALIGNMENT
| +
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0cd586258a2650f715c1af0c9fe4e7063b0409a
Gerrit-Change-Number: 520
Gerrit-PatchSet: 3
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-Reviewer: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-CC: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 11:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment