This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove duplicate inline implementation of issignalingf
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul A. Clarke" <pc at us dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 21 Nov 2019 20:59:16 +0000
- Subject: Re: [PATCH] Remove duplicate inline implementation of issignalingf
- Ironport-sdr: qYUxNI2jlkqVJtUZ8kPxHyrnjc39G0L/zm3xsQuP+69c2vE7vLOP1YLQnvNf1D38niG99qYoDz Qv1Ox6k2dzX2ngjc4ZE9B0ocSsyquC6DhB0s3nyR4xFN02PeBPLpd6Kccez4Dgnquoa7MUAm0h xOfGwfFStRq3bToi+zqZ7szkLctCl07mygIMKA+F9wECfkRLWcrrvvw/636nAUzAMe+dOlyODG hGjiTfO9jxI/PWpQq+jXx/4MlhEaU8h2cIYQORQSmZqRw/eYDvBtD1OTbeQOns61c5PoMgGp6c aFI=
- Ironport-sdr: H3QVAno8NOTD/SwaKM7ZQiO1LdEg3xgLt6ietm02tAKg/6ZfQB9H6FQ4vnFPDqkm9LZVfz6Pnh +boC8xTKJ5OvdgKh8mk3V07WJ+ijRCi6YANZiQfvTUEwBEUQbXoOu2dVS4Kshy7hzOpYVF1VqV llE2/LIP1QgX/rlxZb/QqaaNgWsHG1i5YjSROFheckFeg3BeE0HimHtoaMSeD2Ux8ULrJXQ+Xb khq7S84ZjFaug9tbdy2SsAQYCfEWyjQ+80sGZuyxMWcXZJEbZoJtALRCaOUHRVgpm2R34HEbA7 dWI=
- References: <1574359570-6508-1-git-send-email-pc@us.ibm.com>
On Thu, 21 Nov 2019, Paul A. Clarke wrote:
> From: "Paul A. Clarke" <pc@us.ibm.com>
>
> Very recent commit 854e91bf6b4221f424ffa13b9ef50f35623b7b74 enabled
> inline of issignalingf() in general (__issignalingf in include/math.h).
> There is another implementation for an inline use of issignalingf
> (issignalingf_inline in sysdeps/ieee754/flt-32/math_config.h)
> which could instead make use of the new enablement.
>
> Replace the use of issignalingf_inline with __issignaling.
I think it's better to replace it with calls to issignaling (the
type-generic macro), rather than to __issignalingf (the inline function).
That way, if in future GCC gets __builtin_issignaling and glibc's <math.h>
starts to use it, this code will automatically start using
__builtin_issignaling via the macro definition.
--
Joseph S. Myers
joseph@codesourcery.com