This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[review v4] Don't use a custom wrapper macro around __has_include (bug 25189).


Emilio Cobos Álvarez has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/697
......................................................................


Patch Set 4:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,23 @@ 
| +Parent:     fcb04b9a (Introduce DL_LOOKUP_FOR_RELOCATE flag for _dl_lookup_symbol_x)
| +Author:     Emilio Cobos Álvarez <emilio@crisal.io>
| +AuthorDate: 2019-11-12 19:18:32 +0100
| +Commit:     Emilio Cobos Álvarez <emilio@crisal.io>
| +CommitDate: 2019-11-21 10:32:48 -0500
| +
| +Don't use a custom wrapper macro around __has_include (bug 25189).
| +
| +This causes issues when using clang with -frewrite-includes to e.g., submit the
| +translation unit to a distributed compiler.
| +
| +In my case, I was building Firefox using sccache.
| +
| +See [1] for a reduced test-case since I initially thought this was a clang bug,

PS3, Line 14:

Done. Sorry, my fault, was using 80. Should be fine now :)

| +and [2] for more context.
| +
| +Apparently doing this is invalid C++ per [cpp.cond], which mentions [3]:
| +
| +> The #ifdef and #ifndef directives, and the defined conditional inclusion
| +> operator, shall treat __has_include and __has_cpp_attribute as if they
| +> were the names of defined macros.  The identifiers __has_include and
| +> __has_cpp_attribute shall not appear in any context not mentioned in this
| +> subclause.

-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Id4b8ee19176a9e4624b533087ba870c418f27e60
Gerrit-Change-Number: 697
Gerrit-PatchSet: 4
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fw@deneb.enyo.de>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Emilio Cobos Álvarez <emilio@crisal.io>
Gerrit-Comment-Date: Thu, 21 Nov 2019 16:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Florian Weimer <fweimer@redhat.com>
Gerrit-MessageType: comment


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]