This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v3] Don't use a custom wrapper macro around __has_include (bug 25189).
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Florian Weimer <fweimer at redhat dot com>, Emilio Cobos Álvarez <emilio at crisal dot io>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fw at deneb dot enyo dot de>
- Date: Thu, 21 Nov 2019 11:08:27 -0500
- Subject: [review v3] Don't use a custom wrapper macro around __has_include (bug 25189).
- Auto-submitted: auto-generated
- References: <gerrit.1574340892000.Id4b8ee19176a9e4624b533087ba870c418f27e60@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/697
......................................................................
Patch Set 3:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,23 @@
| +Parent: fcb04b9a (Introduce DL_LOOKUP_FOR_RELOCATE flag for _dl_lookup_symbol_x)
| +Author: Emilio Cobos Álvarez <emilio@crisal.io>
| +AuthorDate: 2019-11-12 19:18:32 +0100
| +Commit: Emilio Cobos Álvarez <emilio@crisal.io>
| +CommitDate: 2019-11-21 10:32:48 -0500
| +
| +Don't use a custom wrapper macro around __has_include (bug 25189).
| +
| +This causes issues when using clang with -frewrite-includes to e.g., submit the
| +translation unit to a distributed compiler.
| +
| +In my case, I was building Firefox using sccache.
| +
| +See [1] for a reduced test-case since I initially thought this was a clang bug,
PS3, Line 14:
Sorry, I'm new to Gerrit and missed that these two lines are very
long. Would you please break them around 72 characters or thereabouts?
Thanks.
| +and [2] for more context.
| +
| +Apparently doing this is invalid C++ per [cpp.cond], which mentions [3]:
| +
| +> The #ifdef and #ifndef directives, and the defined conditional inclusion
| +> operator, shall treat __has_include and __has_cpp_attribute as if they
| +> were the names of defined macros. The identifiers __has_include and
| +> __has_cpp_attribute shall not appear in any context not mentioned in this
| +> subclause.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Id4b8ee19176a9e4624b533087ba870c418f27e60
Gerrit-Change-Number: 697
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fw@deneb.enyo.de>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Emilio Cobos Álvarez <emilio@crisal.io>
Gerrit-Comment-Date: Thu, 21 Nov 2019 16:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment