This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] misc: Set generic pselect as ENOSYS
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org, Lukasz Majewski <lukma at denx dot de>
- Date: Thu, 14 Nov 2019 20:28:24 +0100
- Subject: Re: [PATCH 1/2] misc: Set generic pselect as ENOSYS
- References: <20191114185059.6403-1-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> diff --git a/misc/pselect.c b/misc/pselect.c
> index 76ded850a5..7296b6ef61 100644
> --- a/misc/pselect.c
> +++ b/misc/pselect.c
> @@ -34,43 +34,8 @@ int
Missing header file adjustments?
> diff --git a/sysdeps/unix/sysv/linux/microblaze/pselect.c b/sysdeps/unix/sysv/linux/microblaze/pselect.c
> new file mode 100644
> index 0000000000..62430ca69a
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/microblaze/pselect.c
> + /* The fallback uses 'selects' which shows the race condition regarding
Typo: 'selects' (I think)
> index acda3e0cdd..77a5179925 100644
> --- a/sysdeps/unix/sysv/linux/pselect.c
> +++ b/sysdeps/unix/sysv/linux/pselect.c
> @@ -23,16 +23,6 @@
> #include <kernel-features.h>
> #include <sysdep-cancel.h>
Again I suspect header file cleanups are possible.