This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review] login: Use pread64 in utmp implementation
Carlos O'Donell has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/615
......................................................................
Patch Set 1: Code-Review+2
(16 comments)
OK for master. This looks good to me and removes setting file_offset to -1 which is an odd inconsistent state. We have pread64 for all reads, and lseek/write for the updates, and this makes the logic simpler (thanks to pread64).
| --- login/utmp_file.c
| +++ login/utmp_file.c
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: If21ea0c162c38830a89331ea93cddec14c0974de
Gerrit-Change-Number: 615
Gerrit-PatchSet: 1
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment