[review v2] login: Acquire write lock early in pututline [BZ #24882]

["Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Florian Weimer has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/523
......................................................................


Patch Set 2:

(1 comment)

Not exactly a big comment, but there is now a birds-eye overview.

https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/523/1/login/tst-pututxline-cache.c 
File login/tst-pututxline-cache.c:

https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/523/1/login/tst-pututxline-cache.c@30 
PS1, Line 30: 
25 | #include <support/temp_file.h>
26 | #include <support/xthread.h>
27 | #include <support/xunistd.h>
28 | #include <utmp.h>
29 | #include <utmpx.h>
30 > 
31 | /* Set to the path of the utmp file.  */
32 | static char *utmp_file;
33 | 
34 | /* Used to synchronize the subprocesses.  The barrier itself is
35 |    allocated in shared memory.  */

> This test needs a big comment explaining what the test is doing and why what it is doing is correct, […]

Done



-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I57e31ae30719e609a53505a0924dda101d46372e
Gerrit-Change-Number: 523
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Carlos O'Donell <carlos@redhat.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 19:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Carlos O'Donell <carlos@redhat.com>
Gerrit-MessageType: comment