This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v3] localedef: Add verbose messages for failure paths.
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Thu, 7 Nov 2019 04:01:01 -0500
- Subject: [review v3] localedef: Add verbose messages for failure paths.
- Auto-submitted: auto-generated
- References: <gerrit.1571944987000.I28b9f680711ff00252a2cb15625b774cc58ecb9d@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303
......................................................................
Patch Set 3:
(2 comments)
Mark test comments as done.
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c
File locale/programs/localedef.c:
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c@437
PS3, Line 437:
428 | more_help (int key, const char *text, void *input)
| ...
432 |
433 | switch (key)
434 | {
435 | case ARGP_KEY_HELP_EXTRA:
436 | /* We print some extra information. */
437 > xasprintf (&tp, gettext ("\
438 | For bug reporting instructions, please see:\n\
439 | %s.\n"), REPORT_BUGS_TO);
440 | xasprintf (&cp, gettext ("\
441 | System's directory for character maps : %s\n\
442 | repertoire maps: %s\n\
> Hi Carlos (1).
Done
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c@521
PS3, Line 521:
479 | construct_output_path (char *path)
| ...
516 | n = xasprintf (&result, "%s%s/%s%c", output_prefix ?: "",
517 | COMPLOCALEDIR, path, '\0');
518 | else
519 | n = xasprintf (&result, "%s%s/%.*s%s%s%c",
520 | output_prefix ?: "", COMPLOCALEDIR,
521 > (int) (startp - path), path, normal, endp, '\0');
522 |
523 | endp = result + n - 1;
524 | }
525 | else
526 | {
> Hi Carlos (2).
Done
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I28b9f680711ff00252a2cb15625b774cc58ecb9d
Gerrit-Change-Number: 303
Gerrit-PatchSet: 3
Gerrit-Owner: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Thu, 07 Nov 2019 09:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment