Re: [PATCH 1/2] Add new locale: mnw_MM (Mon language spoken in Myanmar) [BZ #25139]

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

5.11.2019 14:11 Mike FABIAN <mfabian@redhat.com> wrote:
> 
> Add new locale: mnw_MM (Mon language spoken in Myanmar) [BZ #25139]
> 
> From a806c326a646d47f5eff79779599e9ee2a8af2ee Mon Sep 17 00:00:00 2001
> From: Talachan Mon <talachanmon@gmail.com>
> Date: Tue, 5 Nov 2019 10:35:55 +0100
> Subject: [PATCH 1/2] Add new locale: mnw_MM (Mon language spoken in
> Myanmar)
>  [BZ #25139]
> 
> ---
>  NEWS                      |   2 +
>  localedata/SUPPORTED      |   1 +
>  localedata/locales/mnw_MM | 284 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 287 insertions(+)
>  create mode 100644 localedata/locales/mnw_MM
> 
> [...]
> diff --git a/localedata/locales/mnw_MM b/localedata/locales/mnw_MM
> new file mode 100644
> index 0000000000..cf451eda5e
> --- /dev/null
> +++ b/localedata/locales/mnw_MM
> [...]
> +week          7;19971130;1
> +d_t_fmt       "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"

"%Op" probably does nothing, I mean it is equivalent to "%p".
My suggestion is to replace it with "%p".

I wonder: is that correct that the month name is abbreviated ("%b")
while the weekday name is not ("%A")?  Suggestion: use "%a" unless
there is a good reason to use "%A".

Another suggestion: maybe date_fmt should be added already?
Maybe it should be the same as d_t_fmt?  Maybe "%Z" should be
removed from d_t_fmt but not from date_fmt, because this is how
d_t_fmt and date_fmt differ in the C locale?

> +d_fmt         "%OC%Oy %b %Od %A"

The same here.

> +t_fmt         "%OI:%OM:%OS %p"

This looks good.

One more suggestion: is there a good reason to keep those two patches
separated?  Why not to squash them?

I have not reviewed carefully enough and also I have no knowledge about
the Mon language so I can't give my "Reviewed-by" but feel free to commit
(you may accept or reject my suggestions).

Regards,

Rafal