This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 06/30] ldbl-128ibm-compat: Test positional arguments
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 6 Nov 2019 14:28:35 -0300
- Subject: Re: [PATCH v2 06/30] ldbl-128ibm-compat: Test positional arguments
- References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-7-gabriel@inconstante.net.br> <34a497cb-9a69-5c50-c491-5717f7e089c7@linux.ibm.com>
Hi, Paul,
On Mon, 04 Nov 2019, Paul E Murphy wrote:
>OK. Are there any other weird cases which should be tested against? Are
>these meant to be implicit tests of the underlying ABI?
I haven't thought of other weird cases. This test for positional
parameters, as well as the test for double typed variables (previous patch
in this set) check that the relevant code paths in __vfprintf_internal
(added by commit ID 1626f499d159, but not yet fully used so far) are
working as designed. These tests are an attempt to improve the testing of
vfprintf as suggested by Joseph in a somewhat old message [1].
[1] https://sourceware.org/ml/libc-alpha/2018-06/msg00084.html