This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] linux: pselect: Remove CALL_PSELECT6 macro
- From: Florian Weimer <fweimer at redhat dot com>
- To: Lukasz Majewski <lukma at denx dot de>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, Alistair Francis <alistair23 at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Zack Weinberg <zackw at panix dot com>, Carlos O'Donell <carlos at redhat dot com>
- Date: Tue, 05 Nov 2019 14:57:21 +0100
- Subject: Re: [PATCH] linux: pselect: Remove CALL_PSELECT6 macro
- References: <20191105134953.26231-1-lukma@denx.de>
* Lukasz Majewski:
> The CALL_PSELECT6 is now only defined in the sysdeps/unix/sysv/linux/pselect.c
> file and was introduced to allow i386 specific assembler implementation
> of pselec6 (with 6 arguments).
Typo: "pselec6"
> As the i386 now supports pselect6 syscall and the assembler implementation
> (in the sysdeps/unix/sysv/linux/i386/call_pselect6.S) has already been
> removed it is safe to remove this macro define.
I would just say that nothing defines CALL_PSELECT6 in the current tree.
That's enough reason to remove it.
Thanks,
Florian