This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 4 Nov 2019 15:10:41 -0300
- Subject: Re: [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions
- References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-3-gabriel@inconstante.net.br> <6cd56f3e-847f-f1bc-7ae4-f30d58bfdd0a@linux.ibm.com>
Hi, Paul,
On Mon, 04 Nov 2019, Paul E Murphy wrote:
>
>Is it prohibitively difficult to merge the wide character tester with
>the one in the previous patch? Otherwise, this looks OK too.
It's not difficult... In fact, that's how I started it, but it ended up
being too hard to read (imo, anyway), because of the excessive use of
macros and because of the not so nice correspondence between function
names.
I suppose you're suggesting it so that we have less code duplication.
I can make the merge... It's just not how I would do it.