This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [review] Avoid zero-length array at the end of struct link_map [BZ #25097]

From: Carlos O'Donell <carlos at redhat dot com>
To: gnutoolchain-gerrit at osci dot io, Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org, Simon Marchi <simon dot marchi at efficios dot com>
Date: Sun, 3 Nov 2019 16:23:39 -0500
Subject: Re: [review] Avoid zero-length array at the end of struct link_map [BZ #25097]
References: <gerrit.1572801105000.Ic911100730f9124d4ea977ead8e13cee64b84d45@gnutoolchain-gerrit.osci.io> <20191103211914.C04AB25B28@gnutoolchain-gerrit.osci.io>

On 11/3/19 4:19 PM, Carlos O'Donell (Code Review) wrote:
> Carlos O'Donell has posted comments on this change.
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/488
> ......................................................................
> 
> 
> Patch Set 1: Code-Review+2
> 
> (4 comments)
> 
> Looks good to me.
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/488/1/include/link.h 
> File include/link.h:

Simon,

I couldn't be happier about how nice the review looks here:
https://www.sourceware.org/ml/libc-alpha/2019-11/msg00039.html

It captures all my points, and gets them to list so they aren't lost.
The leading and lagging context looks awesome.

Thank you very much for helping with this.

-- 
Cheers,
Carlos.

References:
- [review] Avoid zero-length array at the end of struct link_map [BZ #25097]
  - From: Florian Weimer (Code Review)
- [review] Avoid zero-length array at the end of struct link_map [BZ #25097]
  - From: Carlos O'Donell (Code Review)

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]