This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 01/11] Linux/Alpha: don't use timeval32 system calls.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Alistair Francis <alistair23 at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Lukasz Majewski <lukma at denx dot de>, Zack Weinberg <zackw at panix dot com>
- Date: Mon, 28 Oct 2019 15:13:04 -0300
- Subject: Re: [PATCH v2 01/11] Linux/Alpha: don't use timeval32 system calls.
- References: <20191025120832.27667-1-adhemerval.zanella@linaro.org> <20191025120832.27667-2-adhemerval.zanella@linaro.org> <CAKmqyKMYiUGp-341zbTng-_EB83Hsx_hef2AsNP3Fd-Qu5E=yA@mail.gmail.com>
On 25/10/2019 22:08, Alistair Francis wrote:
> On Fri, Oct 25, 2019 at 5:09 AM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>>
>> From: Zack Weinberg <zackw@panix.com>
>>
[...]
>> +
>> +#include <sys/timex.h>
>> +#include <sysdep.h>
>> +
>> +int
>> +___adjtimex (struct timex *buf)
>> +{
>> + return INLINE_SYSCALL_CALL (adjtimex, buf);
>
> The y2038 safe platforms don't have the adjtimex syscall, instead they
> have the clock_adjtime call. Can this fall back to clock_adjtime if
> __NR_adjtimex isn't defined?
>
> Alistair
>
This change is just a direct transformation from the definition at
syscalls.list (below) to a C implementation.
My plan to add *another* patch on this set to add the specific
adjtimex refactor to make it call __clock_adjtime instead.
>> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list
>> index e374f97b5f..cdcf6c127b 100644
>> --- a/sysdeps/unix/sysv/linux/syscalls.list
>> +++ b/sysdeps/unix/sysv/linux/syscalls.list
>> @@ -1,6 +1,5 @@
>> # File name Caller Syscall name Args Strong name Weak names
>>
>> -adjtimex adjtime adjtimex i:p __adjtimex adjtimex ntp_adjtime
>> alarm - alarm i:i alarm
>> bdflush EXTRA bdflush i:ii __compat_bdflush bdflush@GLIBC_2.0:GLIBC_2.23
>> capget EXTRA capget i:pp capget
>> --
>> 2.17.1
>>