This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v3] localedef: Add verbose messages for failure paths.
- From: "Simon Marchi (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Sun, 27 Oct 2019 11:44:28 -0400
- Subject: [review v3] localedef: Add verbose messages for failure paths.
- Auto-submitted: auto-generated
- References: <gerrit.1571944987000.I28b9f680711ff00252a2cb15625b774cc58ecb9d@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303
......................................................................
Patch Set 3:
(2 comments)
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c
File locale/programs/localedef.c:
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c@437
PS3, Line 437:
428 | more_help (int key, const char *text, void *input)
429 | {
430 | char *cp;
431 | char *tp;
432 |
433 | switch (key)
434 | {
435 | case ARGP_KEY_HELP_EXTRA:
436 | /* We print some extra information. */
437 | xasprintf (&tp, gettext ("\
Hi Carlos (1).
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/3/locale/programs/localedef.c@521
PS3, Line 521:
479 | construct_output_path (char *path)
| ...
512 | the end of the function we need another byte for the trailing
513 | '/'. */
514 | ssize_t n;
515 | if (normal == NULL)
516 | n = xasprintf (&result, "%s%s/%s%c", output_prefix ?: "",
517 | COMPLOCALEDIR, path, '\0');
518 | else
519 | n = xasprintf (&result, "%s%s/%.*s%s%s%c",
520 | output_prefix ?: "", COMPLOCALEDIR,
521 | (int) (startp - path), path, normal, endp, '\0');
Hi Carlos (2).
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I28b9f680711ff00252a2cb15625b774cc58ecb9d
Gerrit-Change-Number: 303
Gerrit-PatchSet: 3
Gerrit-Owner: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Sun, 27 Oct 2019 15:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment