This is the mail archive of the
mailing list for the glibc project.
Re: [review v3] localedef: Add verbose messages for failure paths.
On 10/25/19 10:56 AM, Joseph Myers wrote:
> On Fri, 25 Oct 2019, Carlos O'Donell (Code Review) wrote:
>> PS1, Line 531: _("failed to allocate space for compiled locale path"));
>>> I think this line is too long. […]
> This is a meta-comment on the formatting of these emails and a test of
> email replies to gerrit:
> "PS1, Line 531:" is not helpful, and just makes the lines in these
> messages longer. Quoted text should just use normal "> " to quote it
> (with the additional leading character "+", "-" or " " when being quoted
> as part of a diff hunk).
Right, I think this falls under the "show more context" issue.
In this response I'm marking a comment as "Done" and I probably should
have said more. I removed the entire line in v2 of the patch, so if you
fetch v2 you'll see it's gone and I'm using xasprintf.