This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: enhance the endloop condition of function handle_input_flag found that the endloop condition is not correct, cause when the loop variable " i " euqal to 16, than the input_flags[16] will be out of bounds. though i think for now the inputs maybe all right, but just enhanced it.
- From: Florian Weimer <fweimer at redhat dot com>
- To: <liqingqing3 at huawei dot com>
- Cc: <libc-alpha at sourceware dot org>, <hushiyuan at huawei dot com>
- Date: Wed, 23 Oct 2019 13:06:09 +0200
- Subject: Re: [PATCH] math: enhance the endloop condition of function handle_input_flag found that the endloop condition is not correct, cause when the loop variable " i " euqal to 16, than the input_flags[16] will be out of bounds. though i think for now the inputs maybe all right, but just enhanced it.
- References: <20191023104737.1048-1-liqingqing3@huawei.com>
> From: l00283554 <liqingqing3@huawei.com>
>
> ---
> math/gen-auto-libm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/math/gen-auto-libm-tests.c b/math/gen-auto-libm-tests.c
> index f15af29..08684c4 100644
> --- a/math/gen-auto-libm-tests.c
> +++ b/math/gen-auto-libm-tests.c
> @@ -1298,7 +1298,7 @@ handle_input_flag (char *arg, input_flag *flag,
> char c = *ep;
> *ep = 0;
> bool found = false;
> - for (input_flag_type i = flag_first_flag; i <= num_input_flag_types; i++)
> + for (input_flag_type i = flag_first_flag; i < num_input_flag_types; i++)
> {
> if (strcmp (arg, input_flags[i]) == 0)
> {
I think the change looks good. Would you please resubmit it with a
properly formatted commit message? Thanks.
Florian