This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Alistair Francis <alistair dot francis at wdc dot com>
- Cc: <libc-alpha at sourceware dot org>, <alistair23 at gmaill dot com>
- Date: Tue, 22 Oct 2019 22:28:09 +0000
- Subject: Re: [PATCH v6 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- Ironport-sdr: 4Zp7F1TS07j3r5cOPouTAj2n/oiNTK/g5jm/i/r3X4xf0hfIHtNMzzso9Rl+bBSeJ5zuLgkr0N Drp8DkTN7BbbiR8zx5RfIcV0I60aJVJ7ndqDerIM92TUDd7YWM5R08RrTSlfNwI4xkWmEv7jw1 +Y5EF4fGY8HmkWle3VZQk5ObFoYXL8Fpkx1mYVD8tMKainCAu0SGih+NGqDgkGVtBKY6y+SJBn eVLzZ85KEglQ+X4cFKmzsjc/q5CCTNsgFufSMeAf9H+L+UCfd0Y9Vv36+UxlovDEMjrdN5raeG QsM=
- Ironport-sdr: 2nBGvKivnzSXPAYE6v4qHHw58q5a/rsvLQ1NUQO/sJx+kYjrjxKclbCv1hv3bwpG6kYdLR1kHx 6Yvskxv6p2giuT7WiHnxvFEGrNyQ7umNGzEjUB8DFmCiSLP8qn9ZCl+QCtCH5F2k6Y5v4r3Rbp rx71CqrHjkXMoTgEVTXiQOwJa6EI3cA9OQJp9L2zw+RHb6ul/tdD8O+DtFq8nAWDaCur8hSk7n 3Wit6DN0hlqbFZE4/OXuuy/qS35S5tOefrs5WrUT0Mp+afp8t2Yzor3CoXMkSp2A2iMrlFCWLY n5g=
- References: <20191022155921.8697-1-alistair.francis@wdc.com>
On Tue, 22 Oct 2019, Alistair Francis wrote:
> diff --git a/sysdeps/unix/sysv/linux/generic/stat-check.c b/sysdeps/unix/sysv/linux/generic/stat-check.c
> new file mode 100644
> index 00000000000..302d2e8c28a
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/generic/stat-check.c
> @@ -0,0 +1,29 @@
> +/* Copyright (C) 2011-2019 Free Software Foundation, Inc.
The new file should have a descriptive comment on its first line, before
the copyright notice. Copyright dates should be 2019 only (there is no
copyrightable content in this file copied from older source files).
> + This file is part of the GNU C Library.
> + Contributed by Alistair Francis <alistair.francis@wdc.com> 2019
No "Contributed by" lines in new source files. Contributors should be
thanked in contrib.texi (with contributions described at the logical level
rather than listing specific source files).
The patch is OK with those fixes.
--
Joseph S. Myers
joseph@codesourcery.com